Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupList Retrieval by RoleName #299

Merged
merged 7 commits into from
Aug 31, 2021
Merged

GroupList Retrieval by RoleName #299

merged 7 commits into from
Aug 31, 2021

Conversation

krisztianganyi
Copy link
Contributor

Our specific use case requires us to be able to retrieve a list of groups based on a RoleName we passed to our backend.
My modifications contain the necessary method to do so.

Added method to get groups by RoleID
Added method to retrieve groupList based on RoleName
@Nerzal
Copy link
Owner

Nerzal commented Aug 20, 2021

Hi, thank you for the contribution!
Can you try to merge in the current main branch? It looks like, your work is based on an old commit

@krisztianganyi
Copy link
Contributor Author

Hey, merged the latest version of your main to my fork, now it only contains a minimal amount of changes accross the 2 files.
Please take a look at it.
Thanks!

@Nerzal Nerzal merged commit 053d3e9 into Nerzal:main Aug 31, 2021
@Nerzal
Copy link
Owner

Nerzal commented Aug 31, 2021

thanks for your contribution.
LGTM now merging.

Note: it will take some time until a new tag is being released due to broken pipelines and manual testing effort on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants